Skip to content

Commit f4f8b5d

Browse files
Merge pull request #21576 from emberjs/nvp/fix-benchmark
Don't use build for publishing in 'pnpm bench'
2 parents 27355cd + 23eda10 commit f4f8b5d

2 files changed

Lines changed: 3 additions & 8 deletions

File tree

‎bin/benchmark.mjs‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@ Options:
1919
--no-headless run Chrome without headless mode (opens visible browser windows)
2020
2121
Notes:
22-
- This script runs \`pnpm install\` and \`node ./bin/build-for-publishing.cjs\` in both repos.
23-
- build-for-publishing updates files in-place; it will modify your working tree.
22+
- This script runs \`pnpm install\`, \`pnpm build\`, and \`pnpm pack\` in both repos.
2423
- Benchmark apps are built with \`vite build\` and served using \`vite preview\`.
2524
`);
2625
process.exit(0);

‎bin/benchmark/utils.mjs‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -58,12 +58,8 @@ export async function waitForServer(url, { timeout = 30_000, interval = 500 } =
5858

5959
export async function buildEmberSource(cwd) {
6060
await run('pnpm', ['install'], { cwd });
61-
62-
if (existsSync(join(cwd, './bin/build-for-publishing.js'))) {
63-
await run('node', ['./bin/build-for-publishing.js'], { cwd });
64-
return;
65-
}
66-
await run('node', ['./bin/build-for-publishing.cjs'], { cwd });
61+
await run('pnpm', ['build'], { cwd });
62+
await run('pnpm', ['pack'], { cwd });
6763
}
6864

6965
/**

0 commit comments

Comments
 (0)