Temporarily enable GC on CI - #98616
Draft
lukesandberg wants to merge 2 commits into
Draft
Conversation
lukesandberg
added this pull request to stack #98592
September 13, 2026 17:21
Contributor
Failing test suitesCommit: a300130 | About building and testing Next.js
Expand output● instant-nav-panel › SPA captures › should reset the panel and app when pressing the close button from captured SPA state ● instant-nav-panel › SPA captures › should keep params and searchParams RSC content suspended for a captured SPA navigation ● instant-nav-panel › transitions between capture types › should keep the panel in MPA state after capture -> reload and then update to SPA state after client navigation ● instant-nav-panel › history traversals › shows real content on forward after back while awaiting navigation |
lukesandberg
force-pushed
the
gc-11-ci-enable
branch
from
September 13, 2026 18:49
b6449c9 to
1160aff
Compare
…t transient tasks Two dependency sets were pinning tasks that nothing actually reaches: - `cell_dependents` / `cell_dependents_hashed` are redundant with ancestry. A cell dependent is either a child, whose child edge already orders the teardown, or a sibling reached by passing a `ResolvedVc` laterally, which needs a common ancestor that collects both in the same pass. Counting them deadlocked the cycle `NftJsonAsset::content` -> `all_assets_from_entries_filtered`, whose tasks could then never be collected. - `output_dependent` is redundant with `parent_count`. It records a read of a task's *output* -- the `OperationVc` representation -- and those reads go through `connect()`, so the reader is already a child. With both gone the whole `Data`-category condition goes too, so the predicate reads only `Meta`: the cheap shard scan and the authoritative under-guard recheck now get the same answer, rather than the scan being a pre-filter. Also drops the persistent-only filter in `gc_scan_shard`. Transient tasks are session-scoped, but a session can be long, so leaving them uncollected retains whole subgraphs for the life of the process. This was previously blocked by two failures, both of which are stale references that the preceding commit makes non-fatal: a `MustExist` panic when an invalidator named a collected task, and a `Delete` snapshot item for a task with no task type. `dispose_root_task_releases_anchored_subgraph` now expects two collections rather than one: the disposed root is itself transient, so releasing the last reference to the subgraph reclaims the root along with its leaf. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
lukesandberg
force-pushed
the
gc-11-ci-enable
branch
from
September 13, 2026 19:14
1160aff to
a300130
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.