fix(codemod): preserve line endings in new-link transform - #98608
Open
armanbagherim wants to merge 1 commit into
Open
fix(codemod): preserve line endings in new-link transform#98608armanbagherim wants to merge 1 commit into
armanbagherim wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Preserves the original line endings when running the
new-linkcodemod.Added regression tests for both LF and CRLF inputs.
Why?
On Windows, running the
new-linkcodemod could change files using LF line endings to CRLF because the output was generated without specifying a line terminator.This caused unrelated line-ending changes in files modified by the codemod.
How?
The transform detects the line ending used by the source file and passes it to
toSource()as thelineTerminator.Added tests to verify that:
Tested with:
npx pnpm@10.33.0 --filter @next/codemod buildnpx pnpm@10.33.0 --filter @next/codemod test -- transforms/__tests__/new-link.test.jsResult: 12 tests passed.
Fixes #42437