Skip to content

test: run cargo unit tests with miri as well - #97535

Open
mischnic wants to merge 16 commits into
canaryfrom
mischnic/unit-tests-miri
Open

test: run cargo unit tests with miri as well#97535
mischnic wants to merge 16 commits into
canaryfrom
mischnic/unit-tests-miri

Conversation

@mischnic

@mischnic mischnic commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Maybe finds some incorrect unsafe code

TODO:

  • move implementation changes into separate PRs
    • rcstr
    • mmap
    • disable lz compression

@mischnic
mischnic marked this pull request as ready for review August 19, 2026 07:04
@mischnic Graphite App

mischnic commented Aug 19, 2026

Copy link
Graphite. Learn more about <a href=https://github.com/vercel/next.js/pull/"https://stacking.dev/?utm_source=stack-comment%22>stacking. <!-- Current dependencies on/for this PR: -->" data-view-component="true" class="dropdown-item btn-link"> Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions

github-actions Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Failing test suites

Commit: 2fb9ef9 | About building and testing Next.js

pnpm test-dev test/development/app-dir/instant-navs-devtools/instant-navs-devtools.test.ts (job)

  • instant-nav-panel > history traversals > re-arms the capture when navigating back from a captured SPA navigation (DD)
Expand output

● instant-nav-panel › history traversals › re-arms the capture when navigating back from a captured SPA navigation

locator.waitFor: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('[data-testid="dynamic-skeleton"]') to be visible

  278 |     await browser
  279 |       .locator('[data-testid="dynamic-skeleton"]')
> 280 |       .waitFor({ state: 'visible' })
      |        ^
  281 |     await browser
  282 |       .locator('[data-testid="param-skeleton"]')
  283 |       .waitFor({ state: 'visible' })

  at waitFor (development/app-dir/instant-navs-devtools/instant-navs-devtools.test.ts:280:8)
  at Object.expectTargetPageSpaShell (development/app-dir/instant-navs-devtools/instant-navs-devtools.test.ts:834:13)

@github-actions

github-actions Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Stats from current PR

Warning

No stats were collected for Webpack because its stats job did not complete (it failed, was cancelled, or timed out). The results below only cover the bundlers that finished.

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 813ms 813ms ✓ ▁████
Cold (Ready in log) 801ms 811ms ✓ ▁▂▃▅▅
Cold (First Request) 1.282s 1.286s ✓ ▁▁▃▅▆
Warm (Listen) 812ms 813ms ✓ ▁████
Warm (Ready in log) 802ms 805ms ✓ ▁▂▄▆▅
Warm (First Request) 1.276s 1.271s ✓ ▁▂▃▇▅

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 5.694s 5.670s ✓ ▁▁▁▇▇
Cached Build 2.919s 2.896s ✓ ▁▁▁▅▇
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
node_modules Size 553 MB 553 MB ✓ █████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles
Canary PR Change
017_4moyv5m34.js gzip 117 B 117 B ✓
05jocc85-b73_.js gzip 341 B N/A -
096twxhe86hwd.js gzip 7.53 kB N/A -
0cz1d0mv5g_q7.js gzip 39.4 kB 39.4 kB ✓
0e5lgz-xcf6ln.js gzip 273 B 273 B ✓
0enhddgqs2dl-.js gzip 265 B 265 B ✓
0h34mejwa_7pd.js gzip 354 B 354 B ✓
0w853zxni3ro0.js gzip 1.36 kB N/A -
1-j27ycnrp24e.js gzip 71.5 kB N/A -
13lq2aw3_0bgw.js gzip 3.52 kB N/A -
1elt1qium-r2m.css gzip 115 B 115 B ✓
1m5vdnlf0deiv.js gzip 411 B 411 B ✓
1nigpy_mr0xvj.js gzip 339 B N/A -
1p0l8mn2wz5f2.js gzip 1.97 kB N/A -
1s-3t9k2_uhom.js gzip 117 B N/A -
1sqoyy39jpgkq.js gzip 121 B 121 B ✓
1tf1phijqlx9j.js gzip 220 B 220 B ✓
2-54v5vj7orwp.js gzip 46.8 kB N/A -
2b05_424u1zq-.js gzip 120 B N/A -
2ca40xittx95r.js gzip 8.75 kB N/A -
2hgz42b8sldyc.js gzip 5.85 kB N/A -
2j02uk1ob2zes.js gzip 155 B N/A -
2kci0vnt-49o-.js gzip 113 B 113 B ✓
2sxgl_rcrrn_p.js gzip 399 B N/A -
2u_p__ndkooh-.js gzip 5.66 kB N/A -
2vt62i17bhbdu.js gzip 2.35 kB N/A -
342di-crrg9kq.js gzip 119 B N/A -
36hfc2_979aw2.js gzip 119 B N/A -
38wfp6jjrrdfm.js gzip 131 B 131 B ✓
3dl1ilk37-30g.js gzip 117 B N/A -
3h0us7yy7bd_o.js gzip 13.1 kB N/A -
3kvxagoobts7h.js gzip 117 B N/A -
3p99hd9vwe6ae.js gzip 13 kB N/A -
3r0475panhk6m.js gzip 123 B N/A -
3s0i-weykgzrt.js gzip 125 B N/A -
3wijk2ywqgsv9.js gzip 2.52 kB N/A -
41kebu3wv5f4d.js gzip 65.5 kB N/A -
41u5s3oe2-erp.js gzip 2.29 kB N/A -
turbopack-0d..9ejy.js gzip 3.74 kB 3.74 kB ✓
02zc7sqlpqxn3.js gzip N/A 119 B -
0e28eh3gbwmp0.js gzip N/A 3.51 kB -
0jwho9fkrb_t3.js gzip N/A 2.29 kB -
0longconn5mlm.js gzip N/A 123 B -
0p4l3ozbez2cz.js gzip N/A 2.35 kB -
0sbh_15ejop4o.js gzip N/A 13 kB -
0skdm-9rpid8g.js gzip N/A 117 B -
0wv-h56sz83wn.js gzip N/A 120 B -
1_to3gb2_pcj4.js gzip N/A 65.5 kB -
137xup2t69ovc.js gzip N/A 1.97 kB -
1fk10s3m1oecx.js gzip N/A 400 B -
1hfmb19p0_s-a.js gzip N/A 71.5 kB -
1mxl0dqw8ap5y.js gzip N/A 154 B -
20qhkyyj2_tla.js gzip N/A 116 B -
25lb_468wpv8t.js gzip N/A 117 B -
2imyufe18bsb7.js gzip N/A 1.36 kB -
2p4n3-8-xixh_.js gzip N/A 341 B -
2vqdfieehz5do.js gzip N/A 8.75 kB -
2x99jdcpr5n8x.js gzip N/A 7.53 kB -
2xn85ykzw2v1e.js gzip N/A 13.1 kB -
34knadd6wu9qg.js gzip N/A 119 B -
37-g1kp39exux.js gzip N/A 5.85 kB -
39jq2b6t6z6up.js gzip N/A 339 B -
3a9a9tvkag_-j.js gzip N/A 2.52 kB -
3d61tgick8g6b.js gzip N/A 46.8 kB -
3hk-fj9wj-l1s.js gzip N/A 5.66 kB -
3t121tj-h0kbm.js gzip N/A 125 B -
Total 299 kB 299 kB ⚠️ +3 B

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 1.02 kB 1.02 kB ✓
Total 1.02 kB 1.02 kB ⚠️ +1 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 846 B 846 B ✓
Total 846 B 846 B ✓
Build Cache
Canary PR Change
00000001.sst gzip 14.1 MB 12.3 MB 🟢 1.81 MB (-13%)
00000002.sst gzip 13.9 MB 13.5 MB 🟢 484 kB (-3%)
00000003.sst gzip 13.4 MB 14.2 MB 🔴 +815 kB (+6%)
00000004.sst gzip 13.3 MB 14.8 MB 🔴 +1.5 MB (+11%)
00000005.sst gzip 10.1 MB 2.75 MB 🟢 7.32 MB (-73%)
00000006.sst gzip 2.75 MB 10.1 MB 🔴 +7.31 MB (+266%)
00000007.sst gzip 59 B 59 B ✓
00000008.meta gzip 89 B 89 B ✓
00000009.meta gzip 297 kB 297 kB ✓
00000010.meta gzip 297 kB 297 kB ✓
00000011.meta gzip 297 kB 297 kB ✓
00000012.sst gzip 52.6 kB 52.8 kB ✓
00000013.sst gzip 1.75 MB 1.8 MB 🔴 +52.1 kB (+3%)
00000014.sst gzip 59 B 59 B ✓
00000015.meta gzip 116 B 116 B ✓
00000016.meta gzip 327 kB 327 kB ✓
00000017.meta gzip 402 kB 404 kB ✓
00000018.sst gzip 53.3 kB 53.7 kB ✓
00000019.sst gzip 1.37 MB 1.36 MB 🟢 11.6 kB (-1%)
00000020.sst gzip 59 B 59 B ✓
00000021.meta gzip 116 B 116 B ✓
00000022.meta gzip 327 kB 327 kB ✓
00000023.meta gzip 372 kB 372 kB ✓
00000024.sst gzip 53.3 kB 53.7 kB ✓
00000025.sst gzip 1.37 MB 1.36 MB 🟢 13.6 kB (-1%)
00000026.sst gzip 59 B 59 B ✓
00000027.meta gzip 116 B 116 B ✓
00000028.meta gzip 327 kB 327 kB ✓
00000029.meta gzip 372 kB 372 kB ✓
00000030.sst gzip 52.7 kB 52.9 kB ✓
00000031.sst gzip 1.37 MB 1.36 MB 🟢 13.7 kB (-1%)
00000032.sst gzip 59 B 59 B ✓
00000033.meta gzip 116 B 116 B ✓
00000034.meta gzip 327 kB 327 kB ✓
00000035.meta gzip 372 kB 372 kB ✓
00000036.sst gzip 53.3 kB 53.6 kB ✓
00000037.sst gzip 1.37 MB 1.36 MB 🟢 13.7 kB (-1%)
00000038.sst gzip 59 B 59 B ✓
00000039.meta gzip 116 B 116 B ✓
00000040.meta gzip 327 kB 327 kB ✓
00000041.meta gzip 372 kB 372 kB ✓
CURRENT gzip 94 B 91 B 🟢 3 B (-3%)
LOG gzip 689 B 664 B 🟢 25 B (-4%)
Total 79.6 MB 79.6 MB ⚠️ +15.2 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 375 kB 375 kB ✓
app-page-exp..prod.js gzip 206 kB 206 kB ✓
app-page-tur...dev.js gzip 374 kB 374 kB ✓
app-page-tur..prod.js gzip 206 kB 206 kB ✓
app-page-tur...dev.js gzip 370 kB 370 kB ✓
app-page-tur..prod.js gzip 204 kB 204 kB ✓
app-page.run...dev.js gzip 371 kB 371 kB ✓
app-page.run..prod.js gzip 204 kB 204 kB ✓
app-route-ex...dev.js gzip 82.5 kB 82.5 kB ✓
app-route-ex..prod.js gzip 55.6 kB 55.6 kB ✓
app-route-tu...dev.js gzip 82.5 kB 82.5 kB ✓
app-route-tu..prod.js gzip 55.6 kB 55.6 kB ✓
app-route-tu...dev.js gzip 82.1 kB 82.1 kB ✓
app-route-tu..prod.js gzip 55.4 kB 55.4 kB ✓
app-route.ru...dev.js gzip 82.1 kB 82.1 kB ✓
app-route.ru..prod.js gzip 55.4 kB 55.4 kB ✓
dev-validati...dev.js gzip 134 kB 134 kB ✓
dev-validati...dev.js gzip 134 kB 134 kB ✓
dev-validati...dev.js gzip 132 kB 132 kB ✓
dev-validati...dev.js gzip 132 kB 132 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 46.2 kB 46.2 kB ✓
pages-api-tu..prod.js gzip 34.3 kB 34.3 kB ✓
pages-api.ru...dev.js gzip 46.2 kB 46.2 kB ✓
pages-api.ru..prod.js gzip 34.3 kB 34.3 kB ✓
pages-turbo....dev.js gzip 54.6 kB 54.6 kB ✓
pages-turbo...prod.js gzip 39.7 kB 39.7 kB ✓
pages.runtim...dev.js gzip 54.6 kB 54.6 kB ✓
pages.runtim..prod.js gzip 39.6 kB 39.6 kB ✓
server.runti..prod.js gzip 65.9 kB 65.9 kB ✓
use-cache-pr...dev.js gzip 73.3 kB 73.3 kB ✓
use-cache-pr...dev.js gzip 73.3 kB 73.3 kB ✓
use-cache-pr...dev.js gzip 71.5 kB 71.5 kB ✓
use-cache-pr...dev.js gzip 71.5 kB 71.5 kB ✓
Total 4.1 MB 4.1 MB ✅ -1 B
📎 Tarball URL 
https://vercel-packages.vercel.app/next/commits/caa0130fcd96bb3ac2276dc60197bb350cf23302/next

Commit: caa0130

vercel[bot]
vercel Bot reviewed Aug 19, 2026
View reviewed changes
Comment thread .github/workflows/build_and_test.yml
@mischnic
mischnic force-pushed the mischnic/unit-tests-miri branch 5 times, most recently from 0600873 to caa0130 Compare August 25, 2026 09:00
@mischnic
mischnic force-pushed the mischnic/unit-tests-miri branch from caa0130 to 7bdc7bf Compare September 9, 2026 11:15
bgw
bgw reviewed Sep 11, 2026
View reviewed changes
Comment thread turbopack/crates/turbo-rcstr/src/tagged_value.rs Outdated
mischnic
mischnic commented Sep 11, 2026
View reviewed changes
Comment thread turbopack/crates/turbo-persistence/src/lib.rs Outdated
bgw
bgw reviewed Sep 11, 2026
View reviewed changes
Comment thread .github/workflows/build_reusable.yml
Comment on lines +39 to +42
needsRustJsInstall:
required: false
description: 'if Rust JS dependencies should be installed'
type: string

@bgw bgw Sep 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems better 👍

@mischnic
mischnic force-pushed the mischnic/unit-tests-miri branch from 7bdc7bf to d5c2019 Compare September 11, 2026 22:10
vercel-fleet-prod Bot and others added 14 commits September 13, 2026 20:03
@vercel-fleet-prod @sokra
dynamic.rs: no integer-to-pointer ops
1073823 
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>

Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
@vercel-fleet-prod @sokra
tagged_value.rs: no integer-pointer conversion
a842302 
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>

Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
@vercel-fleet-prod @sokra
turbo-tasks-malloc: disable mimalloc with miri
9d14372 
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>

Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
@vercel-fleet-prod @sokra
ci: decouple needsNextest from needsRustJsInstall
52f5965 
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>

Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
@vercel-fleet-prod @sokra
test: run cargo unit tests with miri as well
c2c5e6c 
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>

Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
@vercel-fleet-prod @sokra
fixup test
d89f8c8 
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>

Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
@vercel-fleet-prod @sokra
cleanup
e5d5674 
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>

Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
@vercel-fleet-prod @sokra
cleanup
3d4928a 
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>

Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
@vercel-fleet-prod @sokra
move flag
be059c6 
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>

Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
@vercel-fleet-prod @sokra
improve
06d52e3 
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>

Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
@vercel-fleet-prod @sokra
skip some big tests
baa8096 
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>

Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
@vercel-fleet-prod @sokra
change flags
63b8bb8 
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>

Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
@vercel-fleet-prod @sokra
skip
3831f4f 
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>

Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
@vercel-fleet-prod @sokra
fix miri with file access mode
f1c17f9 
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>

Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
vercel-fleet-prod Bot and others added 2 commits September 13, 2026 20:03
@vercel-fleet-prod @sokra
skip slow tests under miri
c724954 
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>

Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
@vercel-fleet-prod @sokra @mischnic
use structural file access under miri
2fb9ef9 
Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>
@sokra
sokra force-pushed the mischnic/unit-tests-miri branch from a25e23d to 2fb9ef9 Compare September 13, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bgw bgw bgw approved these changes
@sokra sokra sokra left review comments
@vercel vercel[bot] vercel[bot] left review comments
@vercel-fleet-prod vercel-fleet-prod[bot] vercel-fleet-prod[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mischnic @bgw @sokra