[BUGFIX] Allow CoreObject#init to be called with no arguments - #21524
Merged
NullVoxPopuli merged 1 commit intoJul 26, 2026
Merged
Conversation
Component.init was fixed in emberjs#20492, but Controller, Route, Service, and other EmberObject subclasses still required an argument via CoreObject because a parameter typed `T | undefined` is still required. Make it optional so `super.init()` type-checks again. Closes emberjs#20483
NullVoxPopuli
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Component.init was fixed in #20492, but Controller, Route, Service, and other EmberObject subclasses still required an argument via CoreObject because a parameter typed
T | undefinedis still required. Make it optional sosuper.init()type-checks again.Closes #20483